terrymanu commented on a change in pull request #11183:
URL: https://github.com/apache/shardingsphere/pull/11183#discussion_r665088794



##########
File path: 
shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/rdl/create.xml
##########
@@ -17,14 +17,14 @@
   -->
 
 <sql-cases>
-    <sql-case id="add-resource-single-without-password" value="ADD RESOURCE 
ds_0(HOST=127.0.0.1,PORT=3306,DB=test0,USER=ROOT);" db-types="DistSQL" />
-    <sql-case id="add-resource-single-with-password" value="ADD RESOURCE 
ds_0(HOST=127.0.0.1,PORT=3306,DB=test0,USER=ROOT,PASSWORD=123456);" 
db-types="DistSQL" />
-    <sql-case id="add-resource-multiple" value="ADD RESOURCE 
ds_0(HOST=127.0.0.1,PORT=3306,DB=test0,USER=ROOT,PASSWORD=123456), 
ds_1(HOST=127.0.0.1,PORT=3306,DB=test1,USER=ROOT,PASSWORD=123456);" 
db-types="DistSQL" />
-    <sql-case id="create-sharding-table-rule" value="CREATE SHARDING TABLE 
RULE t_order (RESOURCES(ms_group_0,ms_group_1), 
SHARDING_COLUMN=order_id,TYPE(NAME=hash_mod,PROPERTIES('sharding-count'=4)), 
GENERATED_KEY(COLUMN=another_id,TYPE(NAME=snowflake,PROPERTIES('worker-id'=123))))"
 db-types="DistSQL" />
-    <sql-case id="create-sharding-binding-table-rule" value="CREATE SHARDING 
BINDING TABLE RULES ((t_order,t_order_item), (t_1,t_2))" db-types="DistSQL" />
-    <sql-case id="create-sharding-broadcast-table-rule" value="CREATE SHARDING 
BROADCAST TABLE RULES(t_1,t_2)" db-types="DistSQL" />
-    <sql-case id="create-static-readwrite-splitting-rule" value="CREATE 
READWRITE_SPLITTING RULE ms_group_0 (WRITE_RESOURCE=primary_ds, 
READ_RESOURCES(replica_ds_0,replica_ds_1), TYPE(NAME=random)))" 
db-types="DistSQL" />
-    <sql-case id="create-dynamic-readwrite-splitting-rule" value="CREATE 
READWRITE_SPLITTING RULE ms_group_1(AUTO_AWARE_RESOURCE=group_0, 
TYPE(NAME=random,PROPERTIES(read_weight='2:1')))" db-types="DistSQL" />
-    <sql-case id="create-database-discovery-rule" value="CREATE DB_DISCOVERY 
RULE ha_group_0 (RESOURCES(resource0,resource1), 
TYPE(NAME=mgr,PROPERTIES(groupName='92504d5b-6dec',keepAliveCron=''))), 
ha_group_1 (RESOURCES(resource2,resource3), 
TYPE(NAME=mgr2,PROPERTIES(groupName='92504d5b-6dec-2',keepAliveCron='')))" 
db-types="DistSQL" />
-    <sql-case id="create-encrypt-rule" value="CREATE ENCRYPT RULE t_encrypt 
(RESOURCE=ds_1, 
COLUMNS((NAME=user_id,PLAIN=user_plain,CIPHER=user_cipher,TYPE(NAME=AES,PROPERTIES('aes-key-value'='123456abc'))),
 (NAME=order_id, CIPHER =order_cipher,TYPE(NAME=MD5))))" db-types="DistSQL" />
+    <distSQL-case id="add-resource-single-without-password" value="ADD 
RESOURCE ds_0(HOST=127.0.0.1,PORT=3306,DB=test0,USER=ROOT);" />

Review comment:
       How about change the xml tag `distSQL-case` to `distsql-case`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to