sandynz commented on issue #9568: URL: https://github.com/apache/shardingsphere/issues/9568#issuecomment-876835489
Hi @tristaZero , I'm working on `User` and `Host` column optimization, it need to transfer `grantee` (including `username` and `hostname`) to underlying and then persist to governance, `grantee` just exists in proxy. I considered 3 ways to transfer: 1. Put `Grantee` and `LogicSQL` in `ExecutionGroupContext`. Easier to extend later, but not sure whether they are related or not. 2. Put `Grantee` and `LogicSQL` in another new context class. Easier to extend later, use a dedicated transferring context. 3. Put `Grantee` in method arguments list. `grantee` is not the core information for executor, not clean enough, after addition, it looks like: `jdbcExecutor.execute(grantee, logicSQL, executionGroupContext, isReturnGeneratedKeys, isExceptionThrown)`. I prefer way 1 or 2, but not sure which one is better. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
