dachuan9e commented on a change in pull request #11262:
URL: https://github.com/apache/shardingsphere/pull/11262#discussion_r667313455
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-dialect/shardingsphere-scaling-postgresql/pom.xml
##########
@@ -34,7 +34,11 @@
<artifactId>shardingsphere-scaling-core</artifactId>
<version>${project.version}</version>
</dependency>
-
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <scope>compile</scope>
Review comment:
It needs during the compilation. Before it use the HikariCP-java7 in
elasticjob-lite-core indirectly.
Meanwhile root pom.xml in ShardingSphere has:
<dependency>
<groupId>com.zaxxer</groupId>
<artifactId>HikariCP</artifactId>
<version>${hikari-cp.version}</version>
<scope>test</scope>
</dependency>
The sub module will inherit it. Therefore scope should be marked compile
explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
