wgy8283335 commented on pull request #11259:
URL: https://github.com/apache/shardingsphere/pull/11259#issuecomment-877890037
> * I created new constructors for `ColumnOrderByItem`,
`ExpressionOrderByItem` and `IndexOrderByItem` without having `OrderDirection`
as a construction parameter. Since Oracle `SELECT` group by clause is not
associated with any order directions, I created those new constructors. I'll
remove them if they aren't recommended.
@tristaZero Do you think it is necessary to add constructor without having
`OrderDirection`, as below:
```
public IndexOrderByItemSegment(final int startIndex, final int
stopIndex, final int columnIndex) {
super(startIndex, stopIndex, OrderDirection.ASC, OrderDirection.ASC);
this.columnIndex = columnIndex;
}
```
We still could use this constructor to create IndexOrderByItemSegment object.
```
public IndexOrderByItemSegment(final int startIndex, final int
stopIndex, final int columnIndex, final OrderDirection orderDirection) {
super(startIndex, stopIndex, orderDirection, OrderDirection.ASC);
this.columnIndex = columnIndex;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
