soulasuna commented on a change in pull request #11285:
URL: https://github.com/apache/shardingsphere/pull/11285#discussion_r669232678
##########
File path:
shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/rewrite/parameter/ShadowParameterRewriter.java
##########
@@ -41,4 +41,8 @@ public final boolean isNeedRewrite(final SQLStatementContext
sqlStatementContext
}
protected abstract boolean isNeedRewriteForShadow(SQLStatementContext
sqlStatementContext);
+
+ protected String getShadowColumn() {
+ return shadowRule.getColumn();
Review comment:
Each subclass is called multiple times, and protected methods are
extracted from the parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
