ThanoshanMV opened a new pull request #11372:
URL: https://github.com/apache/shardingsphere/pull/11372


   #10111 
   
   Hi @wgy8283335, I've added SQL definition for Oracle 
[DELETE](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/DELETE.html#GUID-156845A5-B626-412B-9F95-8869B988ABD7)
 statement. Please check it.
   
   Changes proposed in this pull request:
   - Add Oracle `DELETE` statement.
   - Add test cases.
   - I removed Oracle DB-type for SQL case `delete_with_alias` as it has `AS` 
keyword with the alias.
   - I commented out two SQL case ids 
`delete_with_special_comments_return_without_sharding_value`, and 
`delete_with_special_comments_returning_without_sharding_value` as they aren't 
aligned with Oracle SQL. The SQL parsing fails because of `returningCluase`. 
Previous Oracle `DELETE` rule, didn't have support for  `returningCluase`. So, 
it didn't parse. The below image specifies the SQL parsing using previous 
`DELETE` rule for `delete_with_special_comments_return_without_sharding_value` 
SQL case id :
   
   
![PreviousDeleteStatement](https://user-images.githubusercontent.com/48581379/126044994-8144e109-6e14-411b-81df-2a591b35efd8.png)
   
   - The below image specifies SQL parsing using new `DELETE` rule:
   
![NewDeleteStatement](https://user-images.githubusercontent.com/48581379/126045088-959d0205-960f-4c93-9c77-e790225c2ca4.png)
   
   The above SQL case ids don't have required `INTO` keyword with their 
`returningClause` as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to