strongduanmu commented on a change in pull request #11254:
URL: https://github.com/apache/shardingsphere/pull/11254#discussion_r671926061
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
##########
@@ -176,7 +176,7 @@ private boolean isGettingShardingValuesFromHint(final
ShardingStrategy shardingS
private List<ShardingConditionValue>
getShardingValuesFromShardingConditions(final ShardingRule shardingRule, final
Collection<String> shardingColumns, final ShardingCondition shardingCondition) {
List<ShardingConditionValue> result = new
ArrayList<>(shardingColumns.size());
for (ShardingConditionValue each : shardingCondition.getValues()) {
- Optional<BindingTableRule> bindingTableRule =
shardingRule.findBindingTableRule(logicTableName);
+ Optional<BindingTableRule> bindingTableRule =
shardingRule.findBindingTableRule(each.getTableName().toLowerCase());
Review comment:
@setamv Why does it need to be lowercase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
