zjcnb commented on a change in pull request #11457:
URL: https://github.com/apache/shardingsphere/pull/11457#discussion_r675283227
##########
File path:
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSpherePreparedStatement.java
##########
@@ -410,11 +410,13 @@ private void clearPrevious() throws SQLException {
@Override
public ResultSet getGeneratedKeys() throws SQLException {
Optional<GeneratedKeyContext> generatedKey =
findGeneratedKey(executionContext);
- if (statementOption.isReturnGeneratedKeys() &&
generatedKey.isPresent()) {
+ if (statementOption.isReturnGeneratedKeys() &&
generatedKey.isPresent() && !generatedValues.isEmpty()) {
return new
GeneratedKeysResultSet(generatedKey.get().getColumnName(),
generatedValues.iterator(), this);
}
- if (1 == statements.size()) {
- return statements.iterator().next().getGeneratedKeys();
+ for (PreparedStatement statement : statements) {
Review comment:
yes, i will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
