menghaoranss commented on a change in pull request #11508: URL: https://github.com/apache/shardingsphere/pull/11508#discussion_r676493997
########## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/resource/DropResourceBackendHandlerTest.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.proxy.backend.text.distsql.rdl.resource; + +import org.apache.shardingsphere.distsql.parser.statement.rdl.drop.DropResourceStatement; +import org.apache.shardingsphere.infra.context.metadata.MetaDataContexts; +import org.apache.shardingsphere.infra.distsql.exception.DistSQLException; +import org.apache.shardingsphere.infra.metadata.ShardingSphereMetaData; +import org.apache.shardingsphere.infra.metadata.resource.ShardingSphereResource; +import org.apache.shardingsphere.infra.metadata.rule.ShardingSphereRuleMetaData; +import org.apache.shardingsphere.proxy.backend.communication.jdbc.connection.BackendConnection; +import org.apache.shardingsphere.proxy.backend.context.ProxyContext; +import org.apache.shardingsphere.proxy.backend.response.header.ResponseHeader; +import org.apache.shardingsphere.proxy.backend.response.header.update.UpdateResponseHeader; +import org.apache.shardingsphere.transaction.context.TransactionContexts; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Answers; +import org.mockito.Mock; +import org.mockito.junit.MockitoJUnitRunner; + +import javax.sql.DataSource; +import java.util.Collections; +import java.util.HashMap; + +import static org.junit.Assert.assertTrue; +import static org.mockito.Mockito.when; + +@RunWith(MockitoJUnitRunner.class) +public class DropResourceBackendHandlerTest { Review comment: The class should be `final` ########## File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/rdl/resource/DropResourceBackendHandlerTest.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.proxy.backend.text.distsql.rdl.resource; + +import org.apache.shardingsphere.distsql.parser.statement.rdl.drop.DropResourceStatement; +import org.apache.shardingsphere.infra.context.metadata.MetaDataContexts; +import org.apache.shardingsphere.infra.distsql.exception.DistSQLException; +import org.apache.shardingsphere.infra.metadata.ShardingSphereMetaData; +import org.apache.shardingsphere.infra.metadata.resource.ShardingSphereResource; +import org.apache.shardingsphere.infra.metadata.rule.ShardingSphereRuleMetaData; +import org.apache.shardingsphere.proxy.backend.communication.jdbc.connection.BackendConnection; +import org.apache.shardingsphere.proxy.backend.context.ProxyContext; +import org.apache.shardingsphere.proxy.backend.response.header.ResponseHeader; +import org.apache.shardingsphere.proxy.backend.response.header.update.UpdateResponseHeader; +import org.apache.shardingsphere.transaction.context.TransactionContexts; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Answers; +import org.mockito.Mock; +import org.mockito.junit.MockitoJUnitRunner; + +import javax.sql.DataSource; +import java.util.Collections; +import java.util.HashMap; + +import static org.junit.Assert.assertTrue; +import static org.mockito.Mockito.when; + +@RunWith(MockitoJUnitRunner.class) +public class DropResourceBackendHandlerTest { + + @Mock + private DropResourceStatement dropResourceStatement; + + @Mock + private BackendConnection backendConnection; + + @Mock(answer = Answers.RETURNS_DEEP_STUBS) + private MetaDataContexts metaDataContexts; + + @Mock + private TransactionContexts transactionContexts; + + @Mock + private ShardingSphereMetaData metaData; + + @Mock + private ShardingSphereResource resource; + + @Mock + private DataSource dataSource; + + @Mock + private ShardingSphereRuleMetaData ruleMetaData; + + private DropResourceBackendHandler dropResourceBackendHandler; + + @Before + public void setUp() throws Exception { + dropResourceBackendHandler = new DropResourceBackendHandler(dropResourceStatement, backendConnection); + } + + @Test + public void assertExecute() throws DistSQLException { + ProxyContext.getInstance().init(metaDataContexts, transactionContexts); + when(metaDataContexts.getAllSchemaNames()).thenReturn(Collections.singleton("test")); + when(metaDataContexts.getMetaData("test")).thenReturn(metaData); + when(metaData.getResource()).thenReturn(resource); + when(resource.getDataSources()).thenReturn(new HashMap<String, DataSource>() { + { + put("test0", dataSource); + } + } + ); + when(metaData.getRuleMetaData()).thenReturn(ruleMetaData); + when(ruleMetaData.getRules()).thenReturn(Collections.emptyList()); + ResponseHeader responseHeader = dropResourceBackendHandler.execute("test", createDropResourceStatement()); + assertTrue(responseHeader instanceof UpdateResponseHeader); Review comment: Please assert whether resources are deleted, and need to add more case for abnormal process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
