terrymanu commented on a change in pull request #11440:
URL: https://github.com/apache/shardingsphere/pull/11440#discussion_r677118435
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/user/ShardingSphereUser.java
##########
@@ -35,4 +36,18 @@ public ShardingSphereUser(final String username, final
String password, final St
grantee = new Grantee(username, hostname);
this.password = password;
}
+
+ /**
+ * get decrypt password.
+ * @return String the decrypt password
+ */
+ public String getPassword() {
+ try {
+ return
AlgorithmSecureFactory.getInstance().decryptFrontend(password);
+ // CHECKSTYLE:OFF
+ } catch (Exception e) {
+ //checkstyle:ON
+ return null;
Review comment:
If the NPE throw and log, it will make the end users confused, could you
consider about enhance the logic of error handler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
