dachuan9e commented on a change in pull request #11585:
URL: https://github.com/apache/shardingsphere/pull/11585#discussion_r679813136
##########
File path:
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/TransactionAdvice.java
##########
@@ -17,34 +17,35 @@
package org.apache.shardingsphere.agent.metrics.api.advice;
-import java.lang.reflect.Method;
+import org.apache.shardingsphere.agent.api.advice.AdviceTargetObject;
import org.apache.shardingsphere.agent.api.advice.InstanceMethodAroundAdvice;
import org.apache.shardingsphere.agent.api.result.MethodInvocationResult;
-import org.apache.shardingsphere.agent.api.advice.AdviceTargetObject;
-import org.apache.shardingsphere.agent.metrics.api.reporter.MetricsReporter;
-import org.apache.shardingsphere.agent.metrics.api.constant.MethodNameConstant;
+import org.apache.shardingsphere.agent.metrics.api.MetricsPool;
+import org.apache.shardingsphere.agent.metrics.api.constant.MetricIds;
+
+import java.lang.reflect.Method;
/**
* Transaction advice.
*/
public final class TransactionAdvice implements InstanceMethodAroundAdvice {
- private static final String COMMIT = "proxy_transaction_commit_total";
+ public static final String COMMIT = "commit";
- private static final String ROLLBACK = "proxy_transaction_rollback_total";
+ public static final String ROLL_BACK = "rollback";
Review comment:
Good suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
