menghaoranss commented on a change in pull request #11633:
URL: https://github.com/apache/shardingsphere/pull/11633#discussion_r682387703
##########
File path:
examples/shardingsphere-jdbc-example/other-feature-example/encrypt-example/encrypt-raw-jdbc-example/src/main/java/org/apache/shardingsphere/example/encrypt/table/raw/jdbc/config/EncryptDatabasesConfiguration.java
##########
@@ -47,7 +48,7 @@ public DataSource getDataSource() {
encryptAlgorithmConfigs.put("pwd_encryptor", new
ShardingSphereAlgorithmConfiguration("assistedTest", props));
EncryptRuleConfiguration encryptRuleConfig = new
EncryptRuleConfiguration(Collections.singleton(encryptTableRuleConfig),
encryptAlgorithmConfigs);
try {
- return
ShardingSphereDataSourceFactory.createDataSource(DataSourceUtil.createDataSource("demo_ds"),
Collections.singleton(encryptRuleConfig), props);
+ return
ShardingSphereDataSourceFactory.createDataSource(DataSourceUtil.createDataSource("demo_ds"),
Collections.singleton(encryptRuleConfig), props, DefaultSchema.LOGIC_NAME);
Review comment:
I suggest ` ShardingSphereDataSourceFactory` should keep the overload
methods at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
