strongduanmu commented on a change in pull request #11653:
URL: https://github.com/apache/shardingsphere/pull/11653#discussion_r683181654
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -171,7 +171,7 @@ private BindingTableRule createBindingTableRule(final
String bindingTableGroup)
@Override
public Collection<String> getAllTables() {
Collection<String> result = new HashSet<>(getTables());
- result.addAll(getAllActualTables());
+
result.addAll(getAllActualTables().stream().map(String::toLowerCase).collect(Collectors.toList()));
Review comment:
@setamv Is it better to convert lowercase in the `getAllActualTables`
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
