taojintianxia commented on a change in pull request #11655: URL: https://github.com/apache/shardingsphere/pull/11655#discussion_r683124645
########## File path: shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-namespace/src/main/java/org/apache/shardingsphere/spring/namespace/tag/SchemaNameBeanDefinitionTag.java ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.spring.namespace.tag; + +import lombok.AccessLevel; +import lombok.NoArgsConstructor; + +/** + * schema name bean definition tag. + */ +@NoArgsConstructor(access = AccessLevel.PRIVATE) +public class SchemaNameBeanDefinitionTag { Review comment: is this a final class ? ########## File path: shardingsphere-test/shardingsphere-integration-scaling-test/shardingsphere-integration-scaling-test-mysql/src/test/java/org/apache/shardingsphere/integration/scaling/test/mysql/env/config/SourceConfiguration.java ########## @@ -94,6 +94,6 @@ private static YamlRootRuleConfigurations getShardingJdbcConfiguration(final Str public static DataSource createHostDataSource(final Map<String, YamlTableRuleConfiguration> tableRules) { ShardingSphereJDBCDataSourceConfiguration configuration = getHostConfiguration(tableRules); return new ShardingSphereDataSource(new YamlDataSourceConfigurationSwapper().swapToDataSources(configuration.getRootRuleConfigs().getDataSources()), - new YamlRuleConfigurationSwapperEngine().swapToRuleConfigurations(configuration.getRootRuleConfigs().getRules()), null); + new YamlRuleConfigurationSwapperEngine().swapToRuleConfigurations(configuration.getRootRuleConfigs().getRules()), null, null); Review comment: why pass null as the parameter ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
