strongduanmu commented on a change in pull request #11860:
URL: https://github.com/apache/shardingsphere/pull/11860#discussion_r690852018
##########
File path:
shardingsphere-infra/shardingsphere-infra-context/src/main/java/org/apache/shardingsphere/infra/context/metadata/MetaDataContextsBuilder.java
##########
@@ -37,6 +37,7 @@
import org.apache.shardingsphere.infra.optimize.context.OptimizeContextFactory;
import org.apache.shardingsphere.infra.rule.ShardingSphereRule;
import org.apache.shardingsphere.infra.rule.builder.ShardingSphereRulesBuilder;
+import
org.apache.shardingsphere.infra.rule.builder.ShardingSphereRulesBuilderMaterials;
Review comment:
> materials? or material?
@tristaZero `ShardingSphereRulesBuilderMaterials` is named with reference to
`SchemaBuilderMaterials`. Should the style be consistent?
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/properties/ConfigurationPropertyKey.java
##########
@@ -132,7 +132,12 @@
* Proxy backend query fetch size. A larger value may increase the memory
usage of ShardingSphere Proxy.
* The default value is -1, which means set the minimum value for
different JDBC drivers.
*/
- PROXY_BACKEND_QUERY_FETCH_SIZE("proxy-backend-query-fetch-size", "-1",
int.class);
+ PROXY_BACKEND_QUERY_FETCH_SIZE("proxy-backend-query-fetch-size", "-1",
int.class),
+
+ /**
+ * Whether check single table.
+ */
+ CHECK_SINGLE_TABLE_ENABLED("check-single-table-enabled",
String.valueOf(Boolean.FALSE), boolean.class);
Review comment:
> how about 'allow tables with the same name exist '? Or something like
that.
@tristaZero `allow-duplicate-single-table`?
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/properties/ConfigurationPropertyKey.java
##########
@@ -132,7 +132,12 @@
* Proxy backend query fetch size. A larger value may increase the memory
usage of ShardingSphere Proxy.
* The default value is -1, which means set the minimum value for
different JDBC drivers.
*/
- PROXY_BACKEND_QUERY_FETCH_SIZE("proxy-backend-query-fetch-size", "-1",
int.class);
+ PROXY_BACKEND_QUERY_FETCH_SIZE("proxy-backend-query-fetch-size", "-1",
int.class),
+
+ /**
+ * Whether check single table.
+ */
+ CHECK_SINGLE_TABLE_ENABLED("check-single-table-enabled",
String.valueOf(Boolean.FALSE), boolean.class);
Review comment:
@tristaZero Changing to `allow...` will cause the default value to be
`true`, and when user checks the single table, it needs to be set to `false`,
which is the opposite of using other parameters. Is it better to change to
`check-single-table-duplicate-enabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
