zjcnb commented on a change in pull request #11924:
URL: https://github.com/apache/shardingsphere/pull/11924#discussion_r692972541
##########
File path:
shardingsphere-db-protocol/shardingsphere-db-protocol-mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacket.java
##########
@@ -64,6 +65,8 @@ public void write(final MySQLPacketPayload payload) {
payload.writeStringLenenc(((BigDecimal)
each).toPlainString());
} else if (each instanceof Boolean) {
payload.writeBytesLenenc((Boolean) each ? new byte[]{1} :
new byte[]{0});
+ } else if (each instanceof LocalDateTime) {
+ payload.writeStringLenenc(each.toString().replace("T", "
"));
Review comment:
I think, LocalDateTime is better than SimpleDateFormat. The each
originally belong to LocalDateTime. So i think it maybe needn't use
SimpleDateFormat replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
