soulasuna commented on a change in pull request #12099:
URL: https://github.com/apache/shardingsphere/pull/12099#discussion_r698298609



##########
File path: 
shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/rule/ShadowRule.java
##########
@@ -51,43 +56,95 @@
     
     private final boolean enable;
     
-    private final Map<String, ShadowDataSourceConfiguration> dataSources = new 
LinkedHashMap<>();
-    
-    private final Map<String, ShadowTableConfiguration> tables = new 
LinkedHashMap<>();
+    private final Map<String, String> shadowDataSourceMappings = new 
LinkedHashMap<>();
     
     private final Map<String, ShadowAlgorithm> shadowAlgorithms = new 
LinkedHashMap<>();
     
+    private final Map<String, ShadowTableRule> shadowTableRules = new 
LinkedHashMap<>();
+    
     public ShadowRule(final ShadowRuleConfiguration shadowRuleConfig) {
+        enable = shadowRuleConfig.isEnable();

Review comment:
       isXXXX is added by lombok annotation @getter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to