TeslaCN commented on a change in pull request #1967:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/1967#discussion_r698351121
##########
File path:
elasticjob-lite/elasticjob-lite-spring/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/boot/job/ElasticJobBootstrapConfiguration.java
##########
@@ -95,10 +95,25 @@ private void constructJobBootstraps(final
ElasticJobProperties elasticJobPropert
}
}
+ private void jobExtraConfigurations(final JobConfiguration jobConfig,
final TracingConfiguration<?> tracingConfig) {
+ if (null == tracingConfig) {
+ return;
+ }
+ TracingProperties tracingProperties =
applicationContext.getBean(TracingProperties.class);
Review comment:
What if user configured both `include` and `exclude`? I prefer throwing
an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
