terrymanu commented on a change in pull request #12174:
URL: https://github.com/apache/shardingsphere/pull/12174#discussion_r701167228
##########
File path:
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/it/BaseITCase.java
##########
@@ -84,7 +86,7 @@
}
@Before
- public final void createDataSource() {
+ public void initIt() throws IOException, JAXBException {
Review comment:
`initIt` is not understand. It is better to just rename it as `init`
##########
File path:
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/engine/it/BaseITCase.java
##########
@@ -93,11 +95,11 @@ public final void createDataSource() {
}
@After
- public final void tearDown() throws Exception {
+ public void tearDown() throws Exception {
if (targetDataSource instanceof ShardingSphereDataSource) {
((ShardingSphereDataSource)
targetDataSource).getContextManager().close();
}
- if (dataSourceForReader != null) {
+ if (dataSourceForReader != null && dataSourceForReader instanceof
ShardingSphereDataSource) {
Review comment:
Please rewrite to `null != dataSourceForReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
