sandynz commented on a change in pull request #12318:
URL: https://github.com/apache/shardingsphere/pull/12318#discussion_r707277254
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-dialect/shardingsphere-scaling-postgresql/src/test/java/org/apache/shardingsphere/scaling/postgresql/wal/LogicalReplicationTest.java
##########
@@ -79,14 +81,16 @@ public void assertCreateReplicationStreamSuccess() throws
SQLException {
when(chainedLogicalStreamBuilder.withStartPosition(startPosition)).thenReturn(chainedLogicalStreamBuilder);
when(chainedLogicalStreamBuilder.withSlotName("")).thenReturn(chainedLogicalStreamBuilder);
when(chainedLogicalStreamBuilder.withSlotOption(anyString(),
eq(true))).thenReturn(chainedLogicalStreamBuilder, chainedLogicalStreamBuilder);
- logicalReplication.createReplicationStream(pgConnection, "",
startPosition);
+
Review comment:
Should be no blank line.
##########
File path: shardingsphere-distribution/shardingsphere-proxy-distribution/pom.xml
##########
@@ -45,7 +45,13 @@
<artifactId>postgresql</artifactId>
<scope>runtime</scope>
</dependency>
-
+
+ <dependency>
+ <groupId>org.opengauss</groupId>
+ <artifactId>opengauss-jdbc</artifactId>
+ <scope>runtime</scope>
Review comment:
Could we use `provided` but not `runtime`? Just like mysql-connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
