menghaoranss commented on issue #12383:
URL:
https://github.com/apache/shardingsphere/issues/12383#issuecomment-918759856
> > which version of source code did you use, there's no
`shardingsphere-sharding-executor` in the master, and infra should not rely
directly on `sharding`
>
> Sorry, I typed the wrong module name.
> I mean the route-related classes should not be moved to `sharding` package.
Route is the kernel feature of ShardingSphere, different features such as
`Sharding`, `Readwrite Splitting` and `Encrypt` , etc. have their own routers.
They all need to be loaded into infra through SPI without direct reference just
like this.
```
public PartialSQLRouteExecutor(final Collection<ShardingSphereRule> rules,
final ConfigurationProperties props) {
this.props = props;
routers = OrderedSPIRegistry.getRegisteredServices(SQLRouter.class,
rules);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
