strongduanmu commented on pull request #12185: URL: https://github.com/apache/shardingsphere/pull/12185#issuecomment-919682183
> @strongduanmu hiļ¼some checks run fail in the ShardingRuleTest, the reason is that the method assertGetTables runs incorrectly. The expected value is "LOGIC_TABLE", "SUB_LOGIC_TABLE", but the actual result is "logic_table", "sub_logic_table". I found out that you changed this piece of code on September 2nd. Can you look at this problem? thank you. @chengh1 This change is to optimize shardingsphere's handling of upper and lower case, which is an expected change. You need to compare PR and master branches to ensure that your code is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
