lanchengx commented on a change in pull request #12443:
URL: https://github.com/apache/shardingsphere/pull/12443#discussion_r708888097
##########
File path:
shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-distsql/shardingsphere-shadow-distsql-parser/src/main/java/org/apache/shardingsphere/shadow/distsql/parser/core/ShadowDistSQLStatementVisitor.java
##########
@@ -65,16 +69,26 @@ public ASTNode visitShadowAlgorithmDefinition(final
ShadowAlgorithmDefinitionCon
return new ShadowAlgorithmSegment(algorithmName, algorithmSegment);
}
+ private Properties getAlgorithmProperties(final AlgorithmPropertiesContext
ctx) {
+ Properties result = new Properties();
+ ctx.algorithmProperty().forEach(each -> result.put(new
IdentifierValue(each.key.getText()).getValue(), new
StringLiteralValue(each.value.getText()).getValue()));
+ return result;
+ }
+
@Override
public ASTNode visitAlterShadowRule(final AlterShadowRuleContext ctx) {
List<ShadowRuleSegment> shadowRuleSegments =
ctx.shadowRuleDefinition().stream().map(this::visit).map(each ->
(ShadowRuleSegment) each).collect(Collectors.toList());
return new AlterShadowRuleStatement(shadowRuleSegments);
}
- private Properties getAlgorithmProperties(final AlgorithmPropertiesContext
ctx) {
- Properties result = new Properties();
- ctx.algorithmProperty().forEach(each -> result.put(new
IdentifierValue(each.key.getText()).getValue(), new
StringLiteralValue(each.value.getText()).getValue()));
- return result;
Review comment:
The called method does not follow the calling method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
