strongduanmu commented on a change in pull request #12372:
URL: https://github.com/apache/shardingsphere/pull/12372#discussion_r708898959
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAlterTableTokenGenerator.java
##########
@@ -51,9 +52,9 @@ protected boolean isGenerateSQLTokenForEncrypt(final
SQLStatementContext sqlStat
@Override
public Collection<SQLToken> generateSQLTokens(final
AlterTableStatementContext alterTableStatementContext) {
String tableName =
alterTableStatementContext.getSqlStatement().getTable().getTableName().getIdentifier().getValue();
- Collection<SQLToken> result = new
LinkedList<>(getAddColumnTokens(tableName,
alterTableStatementContext.getSqlStatement().getAddColumnDefinitions()));
- result.addAll(getModifyColumnTokens(tableName,
alterTableStatementContext.getSqlStatement().getModifyColumnDefinitions()));
- Collection<SQLToken> dropCollection = getDropColumnTokens(tableName,
alterTableStatementContext.getSqlStatement().getDropColumnDefinitions());
+ Collection<SQLToken> result = new
LinkedList<>(getAddColumnTokens(DefaultSchema.LOGIC_NAME, tableName,
alterTableStatementContext.getSqlStatement().getAddColumnDefinitions()));
Review comment:
@cheese8 Can we remove this useless param by method overload?
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptCreateTableTokenGenerator.java
##########
@@ -53,7 +54,7 @@ protected boolean isGenerateSQLTokenForEncrypt(final
SQLStatementContext sqlStat
for (int index = 0; index < columns.size(); index++) {
ColumnDefinitionSegment each = columns.get(index);
String columnName =
each.getColumnName().getIdentifier().getValue();
- Optional<EncryptAlgorithm> encryptor =
getEncryptRule().findEncryptor(tableName, columnName);
+ Optional<EncryptAlgorithm> encryptor =
getEncryptRule().findEncryptor(DefaultSchema.LOGIC_NAME, tableName, columnName);
Review comment:
@cheese8 Same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
