Icesource commented on a change in pull request #12634:
URL: https://github.com/apache/shardingsphere/pull/12634#discussion_r716058092
##########
File path:
shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ddl/drop-view.xml
##########
@@ -17,5 +17,5 @@
-->
<sql-cases>
- <sql-case id="drop_view" value="DROP VIEW kinds" db-types="PostgreSQL" />
+ <sql-case id="drop_view" value="DROP VIEW kinds" db-types="PostgreSQL,
SQLServer" />
</sql-cases>
Review comment:
```
<sql-cases>
- <sql-case id="drop_view" value="DROP VIEW kinds" db-types="PostgreSQL"
/>
+ <sql-case id="drop_view" value="DROP VIEW kinds" db-types="PostgreSQL,
SQLServer" />
</sql-cases>
```
@jingshanglu This shows that I added a test on my page instead of deleteing.
It turned out that this test was only performed for PostgreSQL. Since the
delete statement is the same, I also added SQLServer here. I did not delete any
tests and the tests did not fail.
Maybe you read it wrong ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
