terrymanu commented on a change in pull request #12911:
URL: https://github.com/apache/shardingsphere/pull/12911#discussion_r722971825
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleMetaDataTest.java
##########
@@ -0,0 +1,47 @@
+package org.apache.shardingsphere.infra.metadata.rule;
+
+import org.apache.shardingsphere.infra.config.RuleConfiguration;
+import org.apache.shardingsphere.infra.rule.ShardingSphereRule;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Optional;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.*;
Review comment:
Please avoid use import *
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ClassTest1.java
##########
@@ -0,0 +1,4 @@
+package org.apache.shardingsphere.infra.metadata.rule;
+
+public final class ClassTest1 extends ShardingSphereRuleFake {
Review comment:
It is better to rename `Fake` as `Fixture`, just keep consist with
original codes
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ClassTest1.java
##########
@@ -0,0 +1,4 @@
+package org.apache.shardingsphere.infra.metadata.rule;
+
+public final class ClassTest1 extends ShardingSphereRuleFake {
Review comment:
Please avoid name class name as `ClassTest1`, it likes a temporary name.
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/rule/ShardingSphereRuleFake.java
##########
@@ -0,0 +1,10 @@
+package org.apache.shardingsphere.infra.metadata.rule;
+
+import org.apache.shardingsphere.infra.rule.ShardingSphereRule;
+
+public class ShardingSphereRuleFake implements ShardingSphereRule {
+ @Override
+ public String getType() {
+ return "type";
Review comment:
`type` is not make sense, could you rename it to meaningful name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
