RaigorJiang commented on a change in pull request #12995:
URL: https://github.com/apache/shardingsphere/pull/12995#discussion_r726240293
##########
File path:
docs/document/content/others/api-change-history/shardingsphere-jdbc/java-api.en.md
##########
@@ -517,7 +517,7 @@ If type of center is `nacos` with
config-center®istry-center, properties coul
| defaultDatabaseShardingStrategyConfig (?) | ShardingStrategyConfiguration
| Default database sharding strategy |
| defaultTableShardingStrategyConfig (?) | ShardingStrategyConfiguration |
Default table sharding strategy |
| defaultKeyGeneratorConfig (?) | KeyGenerator | Default key generator,
default value is `io.shardingsphere.core.keygen.DefaultKeyGenerator`|
-| masterSlaveRuleConfigs (?) | Collection<MasterSlaveRuleConfiguration> |
Read-write splitting rule configuration |
+| masterSlaveRuleConfigs (?) | Collection<MasterSlaveRuleConfiguration> |
Readwrite-splitting rule configuration |
Review comment:
The content in the `change history` is consistent with the `archived
version`, I think it should not be modified here. Please refer to the
documentation of 3.x:
https://shardingsphere.apache.org/document/legacy/3.x/document/en/manual/sharding-jdbc/configuration/config-java/#shardingruleconfiguration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
