strongduanmu commented on a change in pull request #13115: URL: https://github.com/apache/shardingsphere/pull/13115#discussion_r731442761
########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.parameter; + +import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema; +import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter; +import org.apache.shardingsphere.infra.route.context.RouteContext; +import org.apache.shardingsphere.sharding.rule.ShardingRule; +import org.junit.Test; + +import java.util.Collection; + +import static org.mockito.Mockito.mock; + +public class ShardingParameterRewriterBuilderTest { Review comment: @backdoor20 Please add final for ShardingParameterRewriterBuilderTest. ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.context; + +import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties; +import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext; +import org.apache.shardingsphere.infra.route.context.RouteContext; +import org.apache.shardingsphere.sharding.constant.ShardingOrder; +import org.apache.shardingsphere.sharding.rule.ShardingRule; +import org.junit.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class ShardingSQLRewriteContextDecoratorTest { Review comment: @backdoor20 Please add final for ShardingSQLRewriteContextDecoratorTest. ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewriterBuilderTest.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.parameter; + +import org.apache.shardingsphere.infra.metadata.schema.ShardingSphereSchema; +import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter; +import org.apache.shardingsphere.infra.route.context.RouteContext; +import org.apache.shardingsphere.sharding.rule.ShardingRule; +import org.junit.Test; + +import java.util.Collection; + +import static org.mockito.Mockito.mock; + +public class ShardingParameterRewriterBuilderTest { + + @Test + public void assertGetParameterRewriters() { + ShardingSphereSchema shardingSphereSchema = mock(ShardingSphereSchema.class); + ShardingRule shardingRule = mock(ShardingRule.class); + RouteContext routeContext = mock(RouteContext.class); + ShardingParameterRewriterBuilder shardingParameterRewriterBuilder = new ShardingParameterRewriterBuilder(shardingRule, routeContext); + Collection<ParameterRewriter> actual = shardingParameterRewriterBuilder.getParameterRewriters(shardingSphereSchema); + assert !actual.isEmpty(); Review comment: @backdoor20 Please replace assert with assertThat. ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.context; + +import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties; +import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext; +import org.apache.shardingsphere.infra.route.context.RouteContext; +import org.apache.shardingsphere.sharding.constant.ShardingOrder; +import org.apache.shardingsphere.sharding.rule.ShardingRule; +import org.junit.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class ShardingSQLRewriteContextDecoratorTest { + + @Test + public void assertDecorateForRouteContextWhenIsFederated() { + ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator(); + ShardingRule shardingRule = mock(ShardingRule.class); + ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class); + SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class); + RouteContext routeContext = mock(RouteContext.class); + when(routeContext.isFederated()).thenReturn(true); + shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext); + } + + @Test + public void assertDecorateForRouteContextWhenNotFederated() { + ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator(); + ShardingRule shardingRule = mock(ShardingRule.class); + ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class); + SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class); + RouteContext routeContext = mock(RouteContext.class); + when(routeContext.isFederated()).thenReturn(false); + shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext); + } + + @Test + public void assertGetOrder() { + ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator(); + int actual = shardingSQLRewriteContextDecorator.getOrder(); + assert actual == ShardingOrder.ORDER; Review comment: @backdoor20 Please follow the [code conduct](https://shardingsphere.apache.org/community/en/contribute/code-conduct/). ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecoratorTest.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.context; + +import org.apache.shardingsphere.infra.config.properties.ConfigurationProperties; +import org.apache.shardingsphere.infra.rewrite.context.SQLRewriteContext; +import org.apache.shardingsphere.infra.route.context.RouteContext; +import org.apache.shardingsphere.sharding.constant.ShardingOrder; +import org.apache.shardingsphere.sharding.rule.ShardingRule; +import org.junit.Test; + +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class ShardingSQLRewriteContextDecoratorTest { + + @Test + public void assertDecorateForRouteContextWhenIsFederated() { + ShardingSQLRewriteContextDecorator shardingSQLRewriteContextDecorator = new ShardingSQLRewriteContextDecorator(); + ShardingRule shardingRule = mock(ShardingRule.class); + ConfigurationProperties configurationProperties = mock(ConfigurationProperties.class); + SQLRewriteContext sqlRewriteContext = mock(SQLRewriteContext.class); + RouteContext routeContext = mock(RouteContext.class); + when(routeContext.isFederated()).thenReturn(true); + shardingSQLRewriteContextDecorator.decorate(shardingRule, configurationProperties, sqlRewriteContext, routeContext); Review comment: @backdoor20 Why not make an assertion on sqlRewriteContext? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
