strongduanmu commented on a change in pull request #13334:
URL: https://github.com/apache/shardingsphere/pull/13334#discussion_r738854713
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/dialect/OracleTableMetaDataLoader.java
##########
@@ -104,14 +104,22 @@ private void appendNumberDataType(final Map<String,
Integer> dataTypes) {
private ColumnMetaData loadColumnMetaData(final Map<String, Integer>
dataTypeMap, final ResultSet resultSet, final Collection<String> primaryKeys,
final DatabaseMetaData metaData)
throws SQLException {
String columnName = resultSet.getString("COLUMN_NAME");
- String dataType = resultSet.getString("DATA_TYPE");
+ String dataType = subStringLp(resultSet.getString("DATA_TYPE"));
boolean primaryKey = primaryKeys.contains(columnName);
boolean generated = versionContainsIdentityColumn(metaData) &&
"YES".equals(resultSet.getString("IDENTITY_COLUMN"));
// TODO need to support caseSensitive when version < 12.2.
boolean caseSensitive = versionContainsCollation(metaData) &&
resultSet.getString("COLLATION").endsWith("_CS");
return new ColumnMetaData(columnName, dataTypeMap.get(dataType),
primaryKey, generated, caseSensitive);
}
+ private String subStringLp(final String dataType) {
Review comment:
@tuichenchuxin Is it better to name this method getOriginalDataType?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
