linghengqian opened a new issue #13693:
URL: https://github.com/apache/shardingsphere/issues/13693


   ## Feature Request
   
   **For English only**, other languages will not accept.
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot make decision by current information, 
we will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Is your feature request related to a problem?
   No.
   ### Describe the feature you would like.
   
   In the Slack group of ShardingSphere, Haoran Meng once gave a method to 
configure the `ACL` information of `zookeeper` in the `shardingsphere-proxy`.
   
![image](https://user-images.githubusercontent.com/20187731/142432916-dc90055c-0efc-4d48-a30d-0c311a02550f.png)
   
![image](https://user-images.githubusercontent.com/20187731/142432947-cdeb80e8-a137-4bd4-9c53-d0aa8cfb9cb3.png)
   
   Under the `props` tag of the `mode` tag, there is an attribute that is not 
mentioned in the official website document as `digest`. 
   
![image](https://user-images.githubusercontent.com/20187731/142435913-03b4f930-0542-4106-9d42-dcb19f276046.png)
   
   Through this attribute, you can configure the `id` part in 
`[scheme:id:permissions]` to complete the digest Authentication, but observing 
the source code of `shardingsphere`, it can be seen that this is only limited 
to `digest` ACL verification.
   Take an example as a lead.
   
![image](https://user-images.githubusercontent.com/20187731/142433252-97e14632-2ad5-4e74-b628-17310af46297.png)
   Through the 
`org.apache.shardingsphere.mode.repository.cluster.zookeeper.CuratorZookeeperRepository`
 and 
`org.apache.shardingsphere.mode.repository.cluster.zookeeper.props.ZookeeperPropertyKey`
 these two classes can verify the existence of the `digest` property .
   
![image](https://user-images.githubusercontent.com/20187731/142434356-9843e9f4-519f-48ef-9d76-63b2c9c6af55.png)
   
![image](https://user-images.githubusercontent.com/20187731/142434431-54e3cf0a-1821-4048-840c-f1eb4eb7c939.png)
   
   It is not difficult to know that the nodes in `server-lists` will be 
completely resolved into `zookeeper` addresses.
   Through the ideas given in https://github.com/apache/dubbo-admin/issues/848, 
it is completely possible to configure the `ACL` information through the 
`zookeeper url` instead of the `digest` attribute. At the same time, 
`org.apache.shardingsphere.mode.repository.cluster.etcd.EtcdRepository` does 
not give the special configuration of `basicAuth` properties. It seems that the 
configuration of `zookeeper` as shown in the figure below is completely fine.
   
![image](https://user-images.githubusercontent.com/20187731/142435357-f3f3f5ac-9018-44d9-9c16-2e781b32a5d7.png)
   
![image](https://user-images.githubusercontent.com/20187731/142435647-4779dbca-407e-4a14-92a6-536816b997e2.png)
   
   In summary, I put forward my point-removing the `digest` attribute under the 
`mode` tag will make it easier for users who have been using zookeeper to 
understand the configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to