strongduanmu commented on a change in pull request #13892:
URL: https://github.com/apache/shardingsphere/pull/13892#discussion_r760785698
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -262,6 +276,21 @@ public boolean isAllBindingTables(final Collection<String>
logicTableNames) {
return !result.isEmpty() && result.containsAll(logicTableNames);
}
+ /**
+ * Judge whether logic table is all binding tables.
+ *
+ * @param schema schema
+ * @param sqlStatementContext sqlStatementContext
+ * @param logicTableNames logic table names
+ * @return whether logic table is all binding tables.
Review comment:
>
@menghaoranss Thank you, I will optimize it in next pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
