meSunnySrivastava commented on issue #13792:
URL: 
https://github.com/apache/shardingsphere/issues/13792#issuecomment-987566180


   @tuichenchuxin 
   
   **Could you please confirm my understanding about the steps I have to 
follow?**
   
   _1. Get All SQL files: We have SQL files at the following location
   https://github.com/postgres/postgres/tree/master/src/test/regress/sql
   
   
   2. Run SQLParserEngine: For each SQL files I have to run SQLParserEngine and 
see for which SQL I am getting an exception
   For running SQLParserEngine I can refer to 
https://github.com/tuichenchuxin/extract-sql-for-shardingsphere-parser-test
   
   3.Add to Unsupported: If I find any sql which is causing the exception I 
have to add it to unsupported.xml
   
https://github.com/apache/shardingsphere/blob/master/shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/unsupported/unsupported.xml
   
   4. Confirmation Step: To confirm this I have to run 
UnsupportedSQLParserParameterizedTest.java test. 
   Test should pass and SQLParsingException should be thrown for the SQL which 
I added in step 3._ 
   
   Please correct the step where I have wrong understanding if any. 
   
   **Question: Once I am done processing one sql file do I need to mark that as 
checked in the following issue as well?** 
   https://github.com/apache/shardingsphere/issues/13383
   **or Do I need to mention anywhere which files are done?** 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to