jingshanglu commented on a change in pull request #14075:
URL: https://github.com/apache/shardingsphere/pull/14075#discussion_r769363094
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/tcl/XAStatement.java
##########
@@ -17,10 +17,20 @@
package org.apache.shardingsphere.sql.parser.sql.common.statement.tcl;
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
import
org.apache.shardingsphere.sql.parser.sql.common.statement.AbstractSQLStatement;
/**
* Set transaction statement.
*/
Review comment:
XA statement?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/TCLStatement.g4
##########
@@ -90,5 +90,17 @@ lockOption
;
xid
- : string_ (COMMA_ string_)* numberLiterals?
+ : gtrid ((COMMA_ bqual) (COMMA_ formatID)?)?
Review comment:
@zhfeng Maybe it's better like this:
```
xid
: gtrid=textString (COMMA_ bqual=textString (COMMA_ formatID=NUMBER_)?)?
;
```
and delete `gtrid`,`bqual`,`formatID`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
