strongduanmu commented on a change in pull request #14239:
URL: https://github.com/apache/shardingsphere/pull/14239#discussion_r774824467
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/parameter/impl/EncryptPredicateParameterRewriter.java
##########
@@ -65,8 +66,17 @@ public void rewrite(final ParameterBuilder parameterBuilder,
final SQLStatementC
String tableName = encryptCondition.getTableName();
String columnName = encryptCondition.getColumnName();
return getEncryptRule().findAssistedQueryColumn(tableName,
columnName).isPresent()
- ? getEncryptRule().getEncryptAssistedQueryValues(schemaName,
tableName, columnName, originalValues)
- : getEncryptRule().getEncryptValues(schemaName,
tableName, columnName, originalValues);
+ ? checkSortable(encryptCondition,
getEncryptRule().getEncryptAssistedQueryValues(schemaName, tableName,
columnName, originalValues))
+ : checkSortable(encryptCondition,
getEncryptRule().getEncryptValues(schemaName, tableName, columnName,
originalValues));
+ }
+
+ private List<Object> checkSortable(final EncryptCondition
encryptCondition, final List<Object> values) {
Review comment:
Hi @cheese8, can we remove return result of this method? Judging from
the name of the checkSortable method, it seems that it only checks the values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
