takuya1981 commented on pull request #14561: URL: https://github.com/apache/shardingsphere/pull/14561#issuecomment-1006295362
2 questions. - The class name with the word "Pool" in it is the one to be tested. Is it right?? - Since HikariDataSourcePoolDestroyer.destroy() to be tested is asynchronous and there is no callback, I used Thread.sleep(). It's a bit not good, can I use a library like awaitility? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
