zjcnb commented on pull request #14729: URL: https://github.com/apache/shardingsphere/pull/14729#issuecomment-1018233659
> 1. upgrade snakeyaml 1.16 -> 1.29 > 2. Expand the release coverage of Springframework > 3. Expand the release coverage of Spring boot > 4. Modifying unit tests > > Fixes #13602. > > Changes proposed in this pull request: > > * upgrade snakeyaml 1.16 -> 1.29 > * Expand the release coverage of Springframework > * Expand the release coverage of Spring boot > * Modifying unit tests @SirMin Hi, thank for your submit this pull request, this idea likes good. But i hava a question. First, Springboot 2.x not support use `_` , it 's only support `-`, i think this Springboot problem. ShardingSphere maybe needn't to compatible it. I think throws exception is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
