terrymanu commented on a change in pull request #15045:
URL: https://github.com/apache/shardingsphere/pull/15045#discussion_r791482793
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java
##########
@@ -129,8 +129,8 @@ public ResponseHeader execute() {
refreshMetaData(executionContext);
ExecuteResult executeResultSample = result.iterator().next();
return executeResultSample instanceof QueryResult
- ? processExecuteQuery(executionContext,
result.stream().map(each -> (QueryResult) each).collect(Collectors.toList()),
(QueryResult) executeResultSample)
- : processExecuteUpdate(executionContext,
result.stream().map(each -> (UpdateResult) each).collect(Collectors.toList()));
+ ? processExecuteQuery(executionContext, (List) result,
(QueryResult) executeResultSample)
+ : processExecuteUpdate(executionContext, (List) result);
Review comment:
Can we consider about change the result of
`proxySQLExecutor.execute(executionContext)` as List?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
