[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15069: Add EXPORT SCHEMA CONFIGURATION syntax to DistSQL.

Tue, 25 Jan 2022 19:40:47 -0800 


RaigorJiang commented on a change in pull request #15069:
URL: https://github.com/apache/shardingsphere/pull/15069#discussion_r792293983



##########
File path: 
shardingsphere-distsql/shardingsphere-distsql-parser/src/main/antlr4/imports/RALStatement.g4
##########
@@ -87,6 +87,14 @@ dropTrafficRule
     : DROP TRAFFIC RULE ifExists? ruleName (COMMA ruleName)*
     ;
 
+exportSchema
+    : EXPORT SCHEMA (CONFIGURATION | CONFIG) (FROM schemaName)? (COMMA FILE EQ 
filePath)?
+    ;
+
+filePath
+    : IDENTIFIER

Review comment:
       IDENTIFIER may not be suitable, as path, quotes are required, otherwise: 
`d:\asd` can be parsed successfully, but the result is only "d".
   
![image](https://user-images.githubusercontent.com/5668787/151100236-5a01d28c-c357-473f-86e5-79736df40556.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to