sandynz opened a new pull request #15112: URL: https://github.com/apache/shardingsphere/pull/15112
Changes proposed in this pull request: - Refactor close() in inventory task and incremental task. `channel.close()` should be put in `close()` to avoid `FinishedRecord` be cleared immediately. - Refactor `start()` and `stop()` of AbstractLifecycleExecutor to final. Add abstract `doStart()` and `doStop()` methods. - Refactor AbstractLifecycleExecutor.doStart() and .doStop() to abstract. Then it's easier to implement a sub-type of AbstractLifecycleExecutor. - Eliminate duplicated invocation of AbstractLifecycleExecutor.stop() - Remove Importer.write(). Since `write()` is used internally by Importer, so it's not necessary to put a public method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
