menghaoranss commented on a change in pull request #15122:
URL: https://github.com/apache/shardingsphere/pull/15122#discussion_r793498975
##########
File path:
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-fixture/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
##########
@@ -65,9 +66,26 @@
Collection<SQLValue> result = new LinkedList<>();
int count = 0;
for (String each :
Splitter.on(",").trimResults().splitToList(parameters)) {
- List<String> parameterPair =
Splitter.on(":").trimResults().splitToList(each);
+ List<String> parameterPair = parseParameter(each);
result.add(new SQLValue(parameterPair.get(0),
parameterPair.get(1), ++count));
}
return result;
}
+
+ private List<String> parseParameter(final String each) {
Review comment:
The parameter `each` is hard to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
