[shardingsphere] branch master updated: Remove unnecessary new LinkedHashSet (#15248)

[totalo]

This is an automated email from the ASF dual-hosted git repository.

totalo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 426e16c  Remove unnecessary new LinkedHashSet (#15248)
426e16c is described below

commit 426e16c8cac8b06e0dd575f975eb953332a7d2e5
Author: 吴伟杰 <wuwei...@apache.org>
AuthorDate: Sun Feb 6 09:18:57 2022 +0800

    Remove unnecessary new LinkedHashSet (#15248)
---
 .../route/engine/type/standard/ShardingStandardRoutingEngine.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
 
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
index 6e7cb0a..94a7e6b 100644
--- 
a/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
+++ 
b/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/type/standard/ShardingStandardRoutingEngine.java
@@ -44,7 +44,6 @@ import 
org.apache.shardingsphere.sharding.spi.ShardingAlgorithm;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.LinkedHashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
@@ -204,7 +203,7 @@ public final class ShardingStandardRoutingEngine implements 
ShardingRouteEngine
         if (databaseShardingValues.isEmpty()) {
             return tableRule.getActualDatasourceNames();
         }
-        Collection<String> result = new 
LinkedHashSet<>(databaseShardingStrategy.doSharding(tableRule.getActualDatasourceNames(),
 databaseShardingValues, properties));
+        Collection<String> result = 
databaseShardingStrategy.doSharding(tableRule.getActualDatasourceNames(), 
databaseShardingValues, properties);
         Preconditions.checkState(!result.isEmpty(), "no database route info");
         
Preconditions.checkState(tableRule.getActualDatasourceNames().containsAll(result),
 
                 "Some routed data sources do not belong to configured data 
sources. routed data sources: `%s`, configured data sources: `%s`", result, 
tableRule.getActualDatasourceNames());
@@ -214,8 +213,7 @@ public final class ShardingStandardRoutingEngine implements 
ShardingRouteEngine
     private Collection<DataNode> routeTables(final TableRule tableRule, final 
String routedDataSource, 
                                              final ShardingStrategy 
tableShardingStrategy, final List<ShardingConditionValue> tableShardingValues) {
         Collection<String> availableTargetTables = 
tableRule.getActualTableNames(routedDataSource);
-        Collection<String> routedTables = new 
LinkedHashSet<>(tableShardingValues.isEmpty()
-                ? availableTargetTables : 
tableShardingStrategy.doSharding(availableTargetTables, tableShardingValues, 
properties));
+        Collection<String> routedTables = tableShardingValues.isEmpty() ? 
availableTargetTables : tableShardingStrategy.doSharding(availableTargetTables, 
tableShardingValues, properties);
         Collection<DataNode> result = new LinkedList<>();
         for (String each : routedTables) {
             result.add(new DataNode(routedDataSource, each));