pk-218 commented on a change in pull request #15803:
URL: https://github.com/apache/shardingsphere/pull/15803#discussion_r820097920
##########
File path:
shardingsphere-test/shardingsphere-pipeline-test/src/test/java/org/apache/shardingsphere/data/pipeline/core/metadata/model/PipelineTableMetaDataTest.java
##########
@@ -0,0 +1,50 @@
+package org.apache.shardingsphere.data.pipeline.core.metadata.model;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+
+import java.sql.Types;
+import java.util.List;
+import java.util.Map;
+
+public final class PipelineTableMetaDataTest {
+ private PipelineTableMetaData pipelineTableMetaData;
+ private Map<String, PipelineColumnMetaData> columnMetaDataMap;
+
+ @Before
+ public void setUp() {
+ PipelineColumnMetaData pipelineColumnMetaData = new
PipelineColumnMetaData(0, "test", Types.INTEGER, "INTEGER", true);
+ columnMetaDataMap.put("test_column", pipelineColumnMetaData);
+ pipelineTableMetaData = new PipelineTableMetaData(null,
columnMetaDataMap);
+ }
+
+ @Test
+ public void assertGetColumnMetaDataGivenColumnIndex() {
+ List<String> pipelineTableColumns =
pipelineTableMetaData.getColumnNames();
+ PipelineColumnMetaData actual =
columnMetaDataMap.get(pipelineTableColumns.get(0));
+ assertThat(actual.getOrdinalPosition(), is(0));
+ assertThat(actual.getName(), is("test"));
+ assertThat(actual.getDataType(), is(Types.INTEGER));
+ assertTrue(actual.isPrimaryKey());
+ }
+
+ @Test
+ public void assertGetColumnMetaDataGivenColumnName() {
+ PipelineColumnMetaData actual = columnMetaDataMap.get("test_column");
+ assertThat(actual.getOrdinalPosition(), is(0));
+ assertThat(actual.getName(), is("test"));
+ assertThat(actual.getDataType(), is(Types.INTEGER));
+ assertTrue(actual.isPrimaryKey());
+ }
Review comment:
@sandynz I get a failing test case here while checking for a
non-existent column since `getColumnMetaData` returns `null` here, not `-1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
