strongduanmu commented on a change in pull request #16170: URL: https://github.com/apache/shardingsphere/pull/16170#discussion_r829641302
########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByTokenTest.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.token.pojo; + +import org.junit.Before; +import org.junit.Test; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class OrderByTokenTest { + + private OrderByToken orderByToken; + + @Before + public void setup() { + orderByToken = new OrderByToken(0); + } + + @Test + public void assertToString() { + assertThat(orderByToken.toString(), is(" ORDER BY ")); + } + Review comment: @shreya024 Please remove this uesless blank line. ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByTokenTest.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.token.pojo; + +import org.junit.Before; +import org.junit.Test; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class OrderByTokenTest { + + private OrderByToken orderByToken; + + @Before + public void setup() { + orderByToken = new OrderByToken(0); Review comment: @shreya024 Can you mock OrderByToken with columnLabels and orderDirections? ########## File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/test/java/org/apache/shardingsphere/sharding/rewrite/token/pojo/OrderByTokenTest.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sharding.rewrite.token.pojo; + +import org.apache.shardingsphere.sql.parser.sql.common.constant.OrderDirection; +import org.junit.Before; +import org.junit.Test; + +import java.util.List; + +import static org.hamcrest.CoreMatchers.is; +import static org.junit.Assert.assertThat; + +public final class OrderByTokenTest { + + private OrderByToken orderByToken; + + private List<String> columnLabels; + + private List<OrderDirection> orderDirections; + + @Before + public void setup() { + orderByToken = new OrderByToken(0); + columnLabels = orderByToken.getColumnLabels(); + orderDirections = orderByToken.getOrderDirections(); + columnLabels.add(0, "Test1"); + columnLabels.add(1, "Test2"); + orderDirections.add(0, OrderDirection.ASC); + orderDirections.add(1, OrderDirection.ASC); + } + + @Test + public void assertToString() { + StringBuilder result = new StringBuilder(); Review comment: Hi @shreya024, I think we don't need this logic here. We just need assert toString result, like `assertThat(orderByToken.toString(), is("ORDER BY Test1 ASC, Test2 ASC"));` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
