soulasuna commented on a change in pull request #16270:
URL: https://github.com/apache/shardingsphere/pull/16270#discussion_r832771011
##########
File path:
shardingsphere-mode/shardingsphere-mode-core/src/main/java/org/apache/shardingsphere/mode/manager/ContextManager.java
##########
@@ -80,17 +81,21 @@
private volatile InstanceContext instanceContext;
+ private volatile LockContext lockContext;
+
/**
* Initialize context manager.
*
* @param metaDataContexts meta data contexts
* @param transactionContexts transaction contexts
* @param instanceContext instance context
+ * @param lockContext lock context
*/
- public void init(final MetaDataContexts metaDataContexts, final
TransactionContexts transactionContexts, final InstanceContext instanceContext)
{
+ public void init(final MetaDataContexts metaDataContexts, final
TransactionContexts transactionContexts, final InstanceContext instanceContext,
final LockContext lockContext) {
this.metaDataContexts = metaDataContexts;
this.transactionContexts = transactionContexts;
this.instanceContext = instanceContext;
+ this.lockContext = lockContext;
Review comment:
Because `LockContext` will synchronize the global lock state of the
registry when `Proxy` starts.
Execute before register Online Instance in ContextManager can not be created
inside now.
Will refactor later if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
