sandynz commented on a change in pull request #16360:
URL: https://github.com/apache/shardingsphere/pull/16360#discussion_r834953656
##########
File path:
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java
##########
@@ -168,7 +168,7 @@ public void stopClusterWriteDB(final String jobId) {
@Override
public void stopClusterWriteDB(final String schemaName, final String
jobId) {
LockContext lockContext =
PipelineContext.getContextManager().getLockContext();
- ShardingSphereLock lock =
lockContext.getSchemaLock(schemaName).orElse(lockContext.createSchemaLock(schemaName).orElse(null));
+ ShardingSphereLock lock =
lockContext.getSchemaLock(schemaName).orElse(lockContext.getSchemaLock(schemaName).orElse(null));
Review comment:
Seems one `getSchemaLock` call is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
