totalo commented on issue #12366: URL: https://github.com/apache/shardingsphere/issues/12366#issuecomment-1079721715
> @totalo Thank you for the great job! The example enhancement is completed nearly. > > There are still some tasks need to be done: > > 1. `product`, `mode` and `transaction` in config.yaml could be use multiple values, it is better to name them as `products`, `modes` and `transactions`. > 2. I noticed that example of Proxy can not use mix rule configuration, maybe we can improve it to keep same as JDBC. > 3. The data model is for config loading and template together, we can consider about split them, just add a config object to load config.yaml only. The config.yaml can generate lots of examples, so the config object can derive lots of data model objects. > 4. It is better to add verification for `config.yaml`, to reminder the config error to end users. > 5. We can remove or deprecated the original examples if our new examples are ready. It's my pleasure, I will continue to push forward and continue to improve related functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
