terrymanu opened a new issue, #17957: URL: https://github.com/apache/shardingsphere/issues/17957
- [ ] Extract 3 private methods in `doSharding` method for `doShardingInLocalDate`, `doShardingInLocalTime` amd `doShardingInLocalDateTime` - [ ] The instanceOf judgment is too complicated in method `getDateTimeText`, it is better to use instanceOf TemporalAccessor to judge it and move the instanceOf Instant in front of TemporalAccessor judgment - [ ] The variable name `viewAsLocalDate` and `viewAsLocalTime` in method `getMatchedTables` are difficult to understand. How about rename them as `localDate` and `localTime`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
