zjcnb commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893410832
##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
### Configuration Item Explanation
```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default
value: true
Review Comment:
> I think should be remove this about this configuration :
>
> ```
> {
> "name": "spring.shardingsphere.enabled",
> "type": "java.lang.Boolean",
> "description": "Whether enable shardingsphere or not.",
> "defaultValue": true
> }
> ```
>
> It 's from additional-spring-configuration-metadata.json in
`shardingsphere-jdbc-core-spring-boot-starter` module.
After testing, it seems that it is a feature of springboot. If
`ShardingSphere` do not provide configuration, it can still take effect. So, i
think we can remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
