This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 82a4ac0fbf8 Fix begin for postgresql & opengauss (#18359)
82a4ac0fbf8 is described below
commit 82a4ac0fbf83a8ef78400000ed2b58b37dc51ae9
Author: JingShang Lu <[email protected]>
AuthorDate: Thu Jun 16 14:00:03 2022 +0800
Fix begin for postgresql & opengauss (#18359)
* fix begin for postgresql & opengauss
---
.../backend/exception/InTransactionException.java | 31 ++++++++++++++++++++++
.../transaction/TransactionBackendHandler.java | 27 ++++++++++++++-----
.../frontend/command/CommandExecutorTask.java | 5 ++--
.../DatabaseProtocolFrontendEngineFixture.java | 2 +-
.../proxy/frontend/mysql/MySQLFrontendEngine.java | 2 +-
.../opengauss/OpenGaussFrontendEngine.java | 5 ++--
.../opengauss/err/OpenGaussErrorPacketFactory.java | 4 +++
.../postgresql/PostgreSQLFrontendEngine.java | 5 ++--
.../postgresql/err/PostgreSQLErrPacketFactory.java | 4 +++
...ummyReactiveDatabaseProtocolFrontendEngine.java | 2 +-
.../mysql/command/ReactiveMySQLFrontendEngine.java | 2 +-
.../spi/DatabaseProtocolFrontendEngine.java | 3 ++-
12 files changed, 74 insertions(+), 18 deletions(-)
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/exception/InTransactionException.java
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/exception/InTransactionException.java
new file mode 100644
index 00000000000..31d8a47f610
--- /dev/null
+++
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/exception/InTransactionException.java
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.proxy.backend.exception;
+
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+
+/**
+ * In transaction exception.
+ */
+@Getter
+@RequiredArgsConstructor
+public final class InTransactionException extends BackendException {
+
+ private final String message;
+}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/transaction/TransactionBackendHandler.java
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/transaction/TransactionBackendHandler.java
index 4cf04133af8..0c4a7a55e1a 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/transaction/TransactionBackendHandler.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/transaction/TransactionBackendHandler.java
@@ -18,8 +18,10 @@
package org.apache.shardingsphere.proxy.backend.text.transaction;
import io.vertx.core.Future;
+import org.apache.shardingsphere.infra.database.type.dialect.MySQLDatabaseType;
import
org.apache.shardingsphere.infra.database.type.dialect.OpenGaussDatabaseType;
import
org.apache.shardingsphere.infra.database.type.dialect.PostgreSQLDatabaseType;
+import
org.apache.shardingsphere.proxy.backend.exception.InTransactionException;
import
org.apache.shardingsphere.proxy.backend.communication.TransactionManager;
import
org.apache.shardingsphere.proxy.backend.communication.jdbc.connection.JDBCBackendConnection;
import
org.apache.shardingsphere.proxy.backend.communication.jdbc.transaction.JDBCBackendTransactionManager;
@@ -35,7 +37,6 @@ import
org.apache.shardingsphere.sql.parser.sql.common.statement.tcl.RollbackSta
import
org.apache.shardingsphere.sql.parser.sql.common.statement.tcl.SavepointStatement;
import
org.apache.shardingsphere.sql.parser.sql.common.statement.tcl.SetAutoCommitStatement;
import
org.apache.shardingsphere.sql.parser.sql.common.statement.tcl.TCLStatement;
-import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.tcl.MySQLBeginTransactionStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.tcl.MySQLSetAutoCommitStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.tcl.OpenGaussCommitStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.tcl.OpenGaussRollbackStatement;
@@ -80,8 +81,12 @@ public final class TransactionBackendHandler implements
TextProtocolBackendHandl
private Future<Void> determineFuture(final VertxLocalTransactionManager
transactionManager) {
switch (operationType) {
case BEGIN:
- if (tclStatement instanceof MySQLBeginTransactionStatement &&
connectionSession.getTransactionStatus().isInTransaction()) {
- return transactionManager.commit().compose(unused ->
transactionManager.begin());
+ if
(connectionSession.getTransactionStatus().isInTransaction()) {
+ if (connectionSession.getDatabaseType() instanceof
MySQLDatabaseType) {
+ return transactionManager.commit().compose(unused ->
transactionManager.begin());
+ } else if (connectionSession.getDatabaseType() instanceof
PostgreSQLDatabaseType || connectionSession.getDatabaseType() instanceof
OpenGaussDatabaseType) {
+ return Future.failedFuture(new
InTransactionException("There is already a transaction in progress."));
+ }
}
return transactionManager.begin();
case SAVEPOINT:
@@ -103,10 +108,7 @@ public final class TransactionBackendHandler implements
TextProtocolBackendHandl
public ResponseHeader execute() throws SQLException {
switch (operationType) {
case BEGIN:
- if (tclStatement instanceof MySQLBeginTransactionStatement &&
connectionSession.getTransactionStatus().isInTransaction()) {
- backendTransactionManager.commit();
- }
- backendTransactionManager.begin();
+ handleBegin();
break;
case SAVEPOINT:
handleSavepoint();
@@ -133,6 +135,17 @@ public final class TransactionBackendHandler implements
TextProtocolBackendHandl
return new UpdateResponseHeader(tclStatement);
}
+ private void handleBegin() throws SQLException {
+ if (connectionSession.getTransactionStatus().isInTransaction()) {
+ if (connectionSession.getDatabaseType() instanceof
MySQLDatabaseType) {
+ backendTransactionManager.commit();
+ } else if (connectionSession.getDatabaseType() instanceof
PostgreSQLDatabaseType || connectionSession.getDatabaseType() instanceof
OpenGaussDatabaseType) {
+ throw new InTransactionException("There is already a
transaction in progress.");
+ }
+ }
+ backendTransactionManager.begin();
+ }
+
private void handleSavepoint() throws SQLException {
if (!connectionSession.getTransactionStatus().isInTransaction() &&
checkPostgreSQLOrOpengauss()) {
throw new SQLFeatureNotSupportedException("SAVEPOINT can only be
used in transaction blocks");
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/command/CommandExecutorTask.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/command/CommandExecutorTask.java
index beed7cab77d..a00983717ba 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/command/CommandExecutorTask.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/main/java/org/apache/shardingsphere/proxy/frontend/command/CommandExecutorTask.java
@@ -30,6 +30,7 @@ import
org.apache.shardingsphere.infra.config.props.ConfigurationPropertyKey;
import
org.apache.shardingsphere.proxy.backend.communication.SQLStatementDatabaseHolder;
import org.apache.shardingsphere.proxy.backend.context.ProxyContext;
import
org.apache.shardingsphere.proxy.backend.exception.BackendConnectionException;
+import org.apache.shardingsphere.proxy.backend.exception.BackendException;
import org.apache.shardingsphere.proxy.backend.session.ConnectionSession;
import
org.apache.shardingsphere.proxy.frontend.command.executor.CommandExecutor;
import
org.apache.shardingsphere.proxy.frontend.command.executor.QueryCommandExecutor;
@@ -113,8 +114,8 @@ public final class CommandExecutorTask implements Runnable {
commandExecuteEngine.writeQueryData(context,
connectionSession.getBackendConnection(), (QueryCommandExecutor)
commandExecutor, responsePackets.size());
}
return true;
- } catch (final SQLException ex) {
- databaseProtocolFrontendEngine.handleException(connectionSession);
+ } catch (final SQLException | BackendException ex) {
+ databaseProtocolFrontendEngine.handleException(connectionSession,
ex);
throw ex;
} finally {
commandExecutor.close();
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/fixture/DatabaseProtocolFrontendEngineFixture.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/fixture/DatabaseProtocolFrontendEngineFixture.java
index 59286a4d4d3..8a4f172ea5f 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/fixture/DatabaseProtocolFrontendEngineFixture.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/fixture/DatabaseProtocolFrontendEngineFixture.java
@@ -51,7 +51,7 @@ public final class DatabaseProtocolFrontendEngineFixture
implements DatabaseProt
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
}
@Override
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/MySQLFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/MySQLFrontendEngine.java
index 20d586487d9..6df5b49db04 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/MySQLFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/MySQLFrontendEngine.java
@@ -63,7 +63,7 @@ public final class MySQLFrontendEngine implements
DatabaseProtocolFrontendEngine
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
}
@Override
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/OpenGaussFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/OpenGaussFrontendEngine.java
index f4e8a333aa8..d6a527421c8 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/OpenGaussFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/OpenGaussFrontendEngine.java
@@ -21,6 +21,7 @@ import lombok.AccessLevel;
import lombok.Getter;
import
org.apache.shardingsphere.db.protocol.opengauss.codec.OpenGaussPacketCodecEngine;
import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLServerInfo;
+import
org.apache.shardingsphere.proxy.backend.exception.InTransactionException;
import org.apache.shardingsphere.proxy.backend.session.ConnectionSession;
import org.apache.shardingsphere.proxy.frontend.context.FrontendContext;
import
org.apache.shardingsphere.proxy.frontend.opengauss.authentication.OpenGaussAuthenticationEngine;
@@ -59,8 +60,8 @@ public final class OpenGaussFrontendEngine implements
DatabaseProtocolFrontendEn
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
- if (connectionSession.getTransactionStatus().isInTransaction() &&
!connectionSession.getTransactionStatus().isRollbackOnly()) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
+ if (connectionSession.getTransactionStatus().isInTransaction() &&
!connectionSession.getTransactionStatus().isRollbackOnly() && !(exception
instanceof InTransactionException)) {
connectionSession.getTransactionStatus().setRollbackOnly(true);
}
}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/err/OpenGaussErrorPacketFactory.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/err/OpenGaussErrorPacketFactory.java
index e0367de3708..2e18ce693cd 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/err/OpenGaussErrorPacketFactory.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/err/OpenGaussErrorPacketFactory.java
@@ -24,6 +24,7 @@ import lombok.SneakyThrows;
import
org.apache.shardingsphere.db.protocol.opengauss.packet.command.generic.OpenGaussErrorResponsePacket;
import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLErrorCode;
import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLMessageSeverityLevel;
+import
org.apache.shardingsphere.proxy.backend.exception.InTransactionException;
import
org.apache.shardingsphere.proxy.frontend.postgresql.authentication.exception.InvalidAuthorizationSpecificationException;
import
org.apache.shardingsphere.proxy.frontend.postgresql.authentication.exception.PostgreSQLAuthenticationException;
import
org.apache.shardingsphere.proxy.frontend.postgresql.authentication.exception.PostgreSQLProtocolViolationException;
@@ -70,6 +71,9 @@ public final class OpenGaussErrorPacketFactory {
if (existsServerErrorMessage(cause)) {
return createErrorResponsePacket(getServerErrorMessageMap(cause));
}
+ if (cause instanceof InTransactionException) {
+ return new
OpenGaussErrorResponsePacket(PostgreSQLMessageSeverityLevel.WARNING,
PostgreSQLErrorCode.WARNING.getErrorCode(), cause.getMessage());
+ }
if (cause instanceof SQLException) {
return createErrorResponsePacket((SQLException) cause);
}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLFrontendEngine.java
index 2794f46b75b..93a0b89802f 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLFrontendEngine.java
@@ -23,6 +23,7 @@ import
org.apache.shardingsphere.db.protocol.postgresql.codec.PostgreSQLPacketCo
import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLServerInfo;
import
org.apache.shardingsphere.db.protocol.postgresql.packet.PostgreSQLPacket;
import
org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.PostgreSQLPreparedStatementRegistry;
+import
org.apache.shardingsphere.proxy.backend.exception.InTransactionException;
import org.apache.shardingsphere.proxy.backend.session.ConnectionSession;
import
org.apache.shardingsphere.proxy.frontend.authentication.AuthenticationEngine;
import org.apache.shardingsphere.proxy.frontend.command.CommandExecuteEngine;
@@ -58,8 +59,8 @@ public final class PostgreSQLFrontendEngine implements
DatabaseProtocolFrontendE
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
- if (connectionSession.getTransactionStatus().isInTransaction() &&
!connectionSession.getTransactionStatus().isRollbackOnly()) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
+ if (connectionSession.getTransactionStatus().isInTransaction() &&
!connectionSession.getTransactionStatus().isRollbackOnly() && !(exception
instanceof InTransactionException)) {
connectionSession.getTransactionStatus().setRollbackOnly(true);
}
}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/err/PostgreSQLErrPacketFactory.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/err/PostgreSQLErrPacketFactory.java
index 7b8f9a76e35..0b949049d34 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/err/PostgreSQLErrPacketFactory.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/err/PostgreSQLErrPacketFactory.java
@@ -24,6 +24,7 @@ import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLError
import
org.apache.shardingsphere.db.protocol.postgresql.constant.PostgreSQLMessageSeverityLevel;
import
org.apache.shardingsphere.db.protocol.postgresql.packet.generic.PostgreSQLErrorResponsePacket;
import
org.apache.shardingsphere.proxy.backend.exception.DBCreateExistsException;
+import
org.apache.shardingsphere.proxy.backend.exception.InTransactionException;
import
org.apache.shardingsphere.proxy.backend.exception.DatabaseLockedException;
import
org.apache.shardingsphere.proxy.frontend.postgresql.authentication.exception.InvalidAuthorizationSpecificationException;
import
org.apache.shardingsphere.proxy.frontend.postgresql.authentication.exception.PostgreSQLAuthenticationException;
@@ -50,6 +51,9 @@ public final class PostgreSQLErrPacketFactory {
if (cause instanceof PSQLException && null != ((PSQLException)
cause).getServerErrorMessage()) {
return createErrorResponsePacket(((PSQLException)
cause).getServerErrorMessage());
}
+ if (cause instanceof InTransactionException) {
+ return
PostgreSQLErrorResponsePacket.newBuilder(PostgreSQLMessageSeverityLevel.WARNING,
PostgreSQLErrorCode.WARNING.getErrorCode(), cause.getMessage()).build();
+ }
if (cause instanceof SQLException) {
return createErrorResponsePacket((SQLException) cause);
}
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-core/src/test/java/org/apache/shardingsphere/proxy/frontend/reactive/protocol/fixture/DummyReactiveDatabaseProtocolFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-core/src/test/java/org/apache/shardingsphere/proxy/frontend/reactive/protocol/fixture/DummyReactiveDatabaseProtocolFrontendEngine.java
index ccd24f27182..18cfc4d4ad3 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-core/src/test/java/org/apache/shardingsphere/proxy/frontend/reactive/protocol/fixture/DummyReactiveDatabaseProtocolFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-core/src/test/java/org/apache/shardingsphere/proxy/frontend/reactive/protocol/fixture/DummyReactiveDatabaseProtocolFrontendEngine.java
@@ -57,7 +57,7 @@ public final class
DummyReactiveDatabaseProtocolFrontendEngine implements Reacti
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
}
@Override
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/reactive/mysql/command/ReactiveMySQLFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/reactive/mysql/command/ReactiveMySQLFrontendEngine.java
index 51a40288e33..52a968ebf76 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/reactive/mysql/command/ReactiveMySQLFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-reactive-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/reactive/mysql/command/ReactiveMySQLFrontendEngine.java
@@ -63,7 +63,7 @@ public final class ReactiveMySQLFrontendEngine implements
ReactiveDatabaseProtoc
}
@Override
- public void handleException(final ConnectionSession connectionSession) {
+ public void handleException(final ConnectionSession connectionSession,
final Exception exception) {
}
@Override
diff --git
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-spi/src/main/java/org/apache/shardingsphere/proxy/frontend/spi/DatabaseProtocolFrontendEngine.java
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-spi/src/main/java/org/apache/shardingsphere/proxy/frontend/spi/DatabaseProtocolFrontendEngine.java
index a7b197b7aa4..ec8e2d70a65 100644
---
a/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-spi/src/main/java/org/apache/shardingsphere/proxy/frontend/spi/DatabaseProtocolFrontendEngine.java
+++
b/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-spi/src/main/java/org/apache/shardingsphere/proxy/frontend/spi/DatabaseProtocolFrontendEngine.java
@@ -77,6 +77,7 @@ public interface DatabaseProtocolFrontendEngine extends
TypedSPI {
* Handle exception.
*
* @param connectionSession connection session
+ * @param exception exception
*/
- void handleException(ConnectionSession connectionSession);
+ void handleException(ConnectionSession connectionSession, Exception
exception);
}
