RaigorJiang commented on code in PR #18517:
URL: https://github.com/apache/shardingsphere/pull/18517#discussion_r903709461
##########
shardingsphere-features/shardingsphere-readwrite-splitting/shardingsphere-readwrite-splitting-distsql/shardingsphere-readwrite-splitting-distsql-handler/src/main/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/query/ReadwriteSplittingRuleQueryResultSet.java:
##########
@@ -82,6 +82,7 @@ private Collection<Object> buildDataItem(final
ReadwriteSplittingDataSourceRuleC
Optional<ShardingSphereAlgorithmConfiguration> loadBalancer =
Optional.ofNullable(loadBalancers.get(dataSourceRuleConfig.getLoadBalancerName()));
return Arrays.asList(name,
dataSourceRuleConfig.getAutoAwareDataSourceName().orElse(""),
+ DYNAMIC.equalsIgnoreCase(dataSourceRuleConfig.getType()) ?
dataSourceRuleConfig.getWriteDataSourceQueryEnabled().orElse("") : "",
Review Comment:
Dose the result of `dataSourceRuleConfig.getWriteDataSourceQueryEnabled()`
have a default boolean value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
